Skip to content

Save the reputations table on Classic Era, and skip factions absent from the running version #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uga wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Save the reputations table on Classic Era, and skip factions absent from the running version #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c45442
Skip factions that do not exist in the running version of the game
Aug 1, 2026
aac6465
Save the reputations table on Classic Era
Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions DataStore_Reputations/DataStore_Reputations.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,20 @@ do

local function AddFaction(id, text)
text = text or API_GetFactionNameByID(id)

-- a faction that does not exist in this version of the game has no name here.
-- Registering it anyway would index factionNameToId with nil, which errors out of this
-- whole block and leaves every faction declared below it unregistered.
if not text then return end

factions[id] = text

if not text then
print("no value for id : " .. id)
-- else print("Added", id, text) --debug
end
factionNameToId[text] = id
end
local function RemoveFaction(id)
factionNameToId[factions[id]] = nil
factions[id] = nil
if factions[id] then
factionNameToId[factions[id]] = nil
factions[id] = nil
end
end

AddFaction(21, BF["Booty Bay"])
Expand Down
2 changes: 1 addition & 1 deletion DataStore_Reputations/DataStore_Reputations_Vanilla.toc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
## Version: 2026.07.10
## Dependencies: DataStore
## OptionalDeps: Ace3
## SavedVariables: DataStore_ReputationsDB
## SavedVariables: DataStore_Reputations_Characters
## X-Category: Interface Enhancements
## X-Embeds: Ace3

Expand Down