Expose when a guild member's stored equipment reached us - #12
Open
uga wants to merge 1 commit into
Open
Conversation
MSG_EQUIPMENT_TRANSFER writes lastUpdate next to the inventory it stores, and has done since the guild comm was written. Nothing has ever read it. That matters more here than anywhere else in DataStore. This data does not refresh on its own: it arrives only when the member, or their main, is online and answers a request, so a copy received months ago sits in the table unchanged and is handed out exactly like one received a second ago. A consumer showing it has no way to tell the two apart, and no way to warn anyone. Adds a reader for it, registered next to GetGuildMemberInventoryItem. Our own characters return nothing, deliberately: they are answered from our own tables, which are written as we play, so there is no timestamp to give. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of #11 — different file, no overlap.
MSG_EQUIPMENT_TRANSFERwriteslastUpdatenext to the inventory itstores, and has done since the guild comm was written. Nothing has ever
read it.
That matters more here than elsewhere in DataStore, because this data does
not refresh on its own. It arrives only when the member, or their main, is
online and answers a request. A copy received months ago sits in the table
unchanged and is handed out exactly like one received a second ago, and a
consumer showing it has no way to tell the two apart.
This adds a reader, registered next to
GetGuildMemberInventoryItem.Our own characters return nothing, deliberately: those are answered from
our own tables, which are written as we play, so there is no timestamp to
give and none is wanted.
Used by Thaoky/Altoholic_Cata#29, where the guild equipment panel now shows
the date under the character's name — and says so when it is waiting for an
answer that may never come.
🤖 Generated with Claude Code