Repository navigation
fix: stop fish flags after request text - #17
Draft
sb123sb123 wants to merge 2 commits into
Draft
sb123sb123 wants to merge 2 commits into
sb123sb123 wants to merge 2 commits into
Conversation
Signed-off-by: sb123sb123 <152394158+sb123sb123@users.noreply.github.com>
Signed-off-by: sb123sb123 <152394158+sb123sb123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
Fish flag completions now stop after the request begins, matching Bash and Zsh. The condition skips the values for
-key,-url,-model, and-timeout, stops at--, retains the timeout choices, and preserves filename completion for request text.The added fish smoke test covers the acceptance cases and the
-key=valueform.Validation: the existing CI jobs pass, including Go tests on Ubuntu and macOS for oldstable and stable, plus analyze, fuzz, govulncheck, lint, release build, and CodeQL. The fish smoke test has not run in fish and is not wired into this repository CI, so this PR remains a draft pending target-shell verification.