Repository navigation
ci: make ClassScribe checks substantially faster - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymldocs/**and Markdown-only changesReal timings
Baseline is successful run #17. Final is green run #30 attempt 2; it used fresh hosted runners and no dependency/build cache.
The latest pre-change Windows run was 2m25s, so the final 1m19s is also 45.5% faster than the current baseline. One no-cache run hit a NuGet/network outlier (3m14s Windows; 3m19s workflow); an immediate identical rerun produced the final table above.
What changed
PR/main CI retains:
swift testfor ClassScribe with complete strict concurrencyswift testfor all AudioTap tests with complete strict concurrencydotnet testplus all 182 testsglobal.jsonresolves a compatible installed SDKNormal CI no longer repeats:
swift testrelease.ymlstill owns the exhaustive release build, distributable/DMG validation, Windows package and installer work, smoke checks, checksums, and final asset validation. It is unchanged.Runner and cache evidence
-j 2let SwiftPM choose its own parallelism and passed.global.json10.0.302 withlatestPatchresolved to 10.0.303 and passed.actions/setup-dotnetwas removed.push/mainremains for direct-push coverage; PR checks remain the everyday gate. No commit-message parsing was introduced.Hidden AudioTap failures exposed
Once the redeclaration compiled, three stale assertions from earlier
[skip ci]production changes became visible. Tests now assert the documented current contracts: an empty callback is a transport-health heartbeat, and two input frames remain two master frames before/after flush. Production behavior was not changed.No tests were removed, skipped, or made
continue-on-error.