Repository navigation
fix: harden final processing and remove legacy ASR - #8
Merged
Merged
Conversation
Windows captures correction identity before the first await, serializes overlay read-modify-write per folder and isolates A from B. VAD gets a finite 15s budget with fail-open and preserved caller cancellation on both platforms, plus opt-in monotonic diagnostics. macOS overlaps final ASR and diarization as structured child tasks, persisting the ASR transcript as diarizing before speaker attribution; failure and retry semantics are unchanged. Removes the write-only loadedModelPath field and covers active literals with localization keys.
Drops the unconnected AsrWorker protocol, transports, supervisors, lifecycle helper, fakes and their exclusive tests and fixture on both platforms, plus upstream-only CLAUDE/CONTRIBUTING, RPC/architecture docs and two dead scripts. Syncs README, WINDOWS and DISTRIBUTION with the actual Windows model and the public repository. No behavior change; legacy trees stay as follow-ups.
Teyocesu
force-pushed
the
fix/post-v0.8.0-corrective
branch
from
September 21, 2026 16:49
bb1d048 to
7c1a679
Compare
Reuse a cached JsonSerializerOptions instance and static readonly expected names instead of per-call allocations, matching the warnings-as-errors gate.
ApplyProfessorSelectionAsync and SaveEditsAsync captured session state only after acquiring humanCorrectionGate, so an operation requested on session A could persist against session B opened while waiting. Capture attempt and folder before the first await, no-op after the gate unless the visible session is still exactly the requested one, then read fresh state. Adds deterministic A-to-B regressions without sleeps.
Nested per-stage waits let resample, load and inference each consume a full 15 s budget. Run the whole pipeline under a single shared 15 s deadline with unbounded stages inside, preserving single-flight loading, sticky unavailability and caller cancellation. Adds a deterministic shared-budget regression using a small injected budget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trabajo correctivo post-v0.9.0 (rama sobre main v0.9.0).
Que cambia
Validacion
Fuera de scope