Repository navigation
fix(spec): block-trade proposal cancel/reject; MarginMarket.minimum_quantity (#571) — 22.9.0 - #572
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #571
Changes (22.9.0, minor)
communications.block_trade_proposals.cancel(id)→DELETE /communications/block-trade-proposals/{id}(204), sync + async.communications.block_trade_proposals.reject(id)→POST /communications/block-trade-proposals/{id}/reject(204, no body), sync + async.MarginMarket.minimum_quantity(FixedPointCount, optional; spec-required →PERPS_EXCLUSIONSserver_omits_despite_required).market_resultenum gains''— SDK field is plainstr, no change; Gox-enumNameshint, description text)._generatedregenerated, no diff.METHOD_ENDPOINT_MAP. Version bump + CHANGELOG + docs.Blast radius (hand-written; GitNexus unavailable)
kalshi/resources/communications.py: two new methods appended toBlockTradeProposalsResource/AsyncBlockTradeProposalsResource; reuse existing_delete/_post_voidhelpers (non-idempotent verbs, never retried). No existing method touched.kalshi/perps/models/markets.py: one new optional field with defaultNone; existing payloads and constructors unaffected. Consumers: perps markets list/get, any model_dump output gains one key.Gates
ruff ✅ · mypy ✅ · unit 5122 passed ✅ · strict contracts ✅ (see job log)