Repository navigation
fix(spec): MarketPosition.netting_enabled; Klear history ts filters (#569) — 22.8.0 - #570
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #569
Spec drift (run 41840096378): core spec 3.35.0 → 3.36.0, perps SCM spec params, AsyncAPI description-only.
Changes
MarketPosition.netting_enabled: bool | None = None. The spec marks it required; it's kept optional, with anEXCLUSIONSentry of kindserver_omits_despite_required.*_all:obligation_history: keyword-onlysettlement_start_ts/settlement_end_tssettlement_balance_history: keyword-onlystart_ts/end_tsdatetime | str. A naive datetime is treated as UTC and sent as RFC3339. A parameter is only sent when it isn'tNone.docs/perps.md,docs/resources/portfolio.md).kalshi/_generated/regenerated by the scripts (no diff).Blast radius (hand-written; GitNexus unavailable)
MarketPosition: new optional field. Existing payloads without it still validate, andextra="allow"is unchanged. Users ofportfolio.positionsseeNoneuntil the server sends it.None. Existing calls send exactly the same query as before. The new_rfc3339helper is local tomargin.py. GET requests keep their retry behavior; no POST/PUT/DELETE paths were touched.Gates
ruff pass · mypy pass · unit tests 5088 passed, 3 skipped · strict contract tests 930 passed