Repository navigation
Reconcile perps subtrader require_category_cap drift (v20.0.0) - #532
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #531
Upstream perps OpenAPI now lists
require_category_cap(boolean) as a required property ofCreateMarginFCMSubtraderRequest(POST /margin/fcm/subtraders).Changes
CreateMarginFCMSubtraderRequest.require_category_cap: bool(required;Falseis serialized, not omitted).FcmResource.create_subtraderacceptrequire_category_capand require it alongsidesubtrader_suffixwhen norequest=is passed.specs/perps_openapi.yaml(new field + description-only tweak onMarginMarket.market_version),specs/openapi.yamlinfo.version 3.32.0 → 3.33.0 (no schema change;generate.pyproduced no_generated/diff).Blast radius (GitNexus unavailable on the maintainer box; assessed manually)
Only
kalshi/perps/models/fcm.py::CreateMarginFCMSubtraderRequest,kalshi/perps/resources/fcm.py::_build_create_subtrader_body, and the sync/asynccreate_subtradermethods. No other callers in the package.Gate
uv run ruff check .passuv run mypy kalshi/passuv run pytest tests/ --ignore=tests/integration -qpass (4635 passed, 3 skipped)uv run pytest tests/test_contracts.py -v -W error::UserWarning(nightly strict) pass