Skip to content

docs(README): fix pagination quickstart — has_more → has_next - #276

Merged
TexasCoding merged 1 commit into
mainfrom
fix/248-readme-has-more
May 21, 2026
Merged

TexasCoding merged 1 commit into
mainfrom
fix/248-readme-has-more

Conversation

@TexasCoding

Copy link
Copy Markdown
Owner

Closes #248

Part of #273 (post-v2.4 audit), Wave 0 docs patch.

@claude

claude Bot commented May 21, 2026

Copy link
Copy Markdown

Code Review — PR #276

Overview: Single-line documentation fix correcting has_more → has_next in the README pagination quickstart. Closes #248.


Correctness ✅

The fix is unambiguously right. Page.has_next is the only property defined in kalshi/models/common.py; has_more doesn't exist and would raise AttributeError at runtime for any new user copying the quickstart. Verified:

# kalshi/models/common.py
@property
def has_next(self) -> bool:
    return self.cursor is not None and self.cursor != ""

Consistency ✅

After this change, the README matches every other doc that references this property:

  • docs/pagination.md — uses has_next in three places
  • docs/migration.md — uses has_next
  • docs/resources/portfolio.md — uses has_next

No remaining has_more references anywhere in the codebase.

Minimality ✅

Exactly one line changed. Nothing unnecessary touched. Matches the "surgical changes" guideline in CLAUDE.md.

Test Coverage

N/A — documentation-only change. No code logic affected.

Security / Performance

N/A.


Verdict: LGTM. Clean, correct, and the right minimum fix. No suggestions.

@TexasCoding
TexasCoding merged commit 92fa0ea into main May 21, 2026
5 checks passed
@TexasCoding
TexasCoding deleted the fix/248-readme-has-more branch May 21, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: README pagination quickstart references non-existent Page.has_more (should be has_next)

1 participant