bug: int-typed request fields silently coerce bool (subaccount routing, transfers, counts) #295

from kalshi import CreateOrderRequest
from kalshi.models.subaccounts import ApplySubaccountTransferRequest
from uuid import uuid4

# Silently routes to subaccount 1 — no error
order = CreateOrderRequest(
    ticker="EX-25-T", side="yes", action="buy",
    count=10, yes_price="0.50", subaccount=True,
)
print(order.subaccount, type(order.subaccount))  # 1 <class 'int'>

# Silently transfers 1 cent from subaccount 1 to subaccount 1
xfer = ApplySubaccountTransferRequest(
    client_transfer_id=uuid4(),
    from_subaccount=True,   # → 1
    to_subaccount=True,     # → 1
    amount_cents=True,      # → 1
)
print(xfer.from_subaccount, xfer.to_subaccount, xfer.amount_cents)  # 1 1 1

CreateOrderRequest(ticker=..., side=..., action="buy", count=1, buy_max_cost=True)
# ValidationError: buy_max_cost must be int (cents), not bool — bool is an int subclass...

def _reject_bool_int(value: object) -> object:
    """Reject ``bool`` on ``int`` fields. ``bool`` is an ``int`` subclass, so
    ``Pydantic`` coerces ``True``→1 / ``False``→0 silently — see #243 for the
    money-risk this caused on ``buy_max_cost`` before the explicit guard.
    """
    if isinstance(value, bool):
        raise ValueError(
            "bool is not a valid int here — pass an explicit integer "
            "(e.g. 1 instead of True). bool is an int subclass so True "
            "would otherwise silently become 1."
        )
    return value


StrictInt = Annotated[int, BeforeValidator(_reject_bool_int)]
"""An ``int`` that rejects ``bool`` to avoid silent True→1 coercion on
money-routing fields (subaccount, exchange_index, contracts_limit,
amount_cents, …). Use on every ``int`` field of a Request model."""

from pydantic import BaseModel
class M(BaseModel):
    x: int
print(M(x=True).x)  # → 1