Errors: content-length cap on error body drops the typed-exception class #252

Summary

A 429 (or 401, 409, 422, 504) whose body advertises >16KB returns a generic KalshiError from _map_error. Two concrete consequences:

1. The retry loop's isinstance(error, KalshiRateLimitError) Retry-After branch is bypassed, so a hostile-but-otherwise-valid 429 with a verbose body falls back to computed backoff and ignores the server's Retry-After hint.
2. Caller code structured as except KalshiRateLimitError / except KalshiAuthError / except KalshiConflictError silently misses these responses.

The size cap (#203) is correct in principle; only the exception class is wrong.

Location

• kalshi/_base_client.py:51-62

Evidence

content_length = response.headers.get("content-length")
if content_length:
    try:
        if int(content_length) > MAX_ERROR_BODY_BYTES:
            return KalshiError(
                message=f"HTTP {status} (body {content_length} bytes, suppressed)",
                status_code=status,
            )
    except ValueError:
        pass

Recommended fix

After the size-check short-circuit, still dispatch on status to the type-specific exception with the suppressed-body message. Easiest: build message = f"HTTP {status} (body {content_length} bytes, suppressed)", set body = {}, then fall through to the existing status dispatch.

Severity & category

medium / consistency