Open
Conversation
Contributor
|
@kaiyaok2 does this work with most of the projects you tried before? |
Contributor
|
@hofi1 Thanks!! The change looks good to me. I'm just wondering if we could remove Python as a dependency (i.e. let bash do all the work). Please review the script Darko shared and feel free to incorporate part of that to this PR (the script worked on my Mac with ~10 projects but I haven't tested it under Linux yet). |
Contributor
|
Thanks for the readme. It can remain the same even if we remove the dependency on Python and use only shell. Can you check Kaiyao's emails for shell only? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a script to modify the gradle files of your project