build(deps-dev): bump websocket-driver past security advisory - #44
Merged
Conversation
eviechan
requested review from
Gustavo-Cauzzi,
beelol,
paulotestbox and
vh-fsantos
August 12, 2026 08:31
paulotestbox
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did I change:
Lockfile-only refresh moving
websocket-driver0.7.4 → 0.7.5, closing the open critical Dependabot alert (#141, GHSA-xv26-6w52-cph6 / CVE-2026-54466 — message corruption via abuse of protocol length headers). The same bump also clears GHSA-mp7j-qc5w-4988 (resource limit bypass via message compression) flagged bynpm auditagainst the same version.websocket-driveris not a direct dependency — it is a dev-only transitive:webpack-dev-server@5.2.4 → sockjs@0.3.24 → faye-websocket@0.11.4 → websocket-driver@0.7.4. Both parent ranges (^0.7.4,>=0.5.1) already admit the patched 0.7.5, so nopackage.jsonchange and no newoverridesentry are needed —npm update websocket-driver --package-lock-onlyis the entire change. The repo has nodependabot.yml, so alerts are raised but fix PRs are never auto-opened; this closes the gap manually.The new lockfile entry's integrity hash was verified against the official registry metadata for
websocket-driver@0.7.5and against a recomputed sha512 of the tarball itself. 0.7.5's own dependency ranges are unchanged from 0.7.4, so no other lockfile entry moved.Commit is typed
build(deps-dev):rather thanfix:so semantic-release does not cut a release for a dev-only lockfile change.QA Notes:
No QA pass needed. The published package ships zero runtime dependencies (
files: ["lib/"], nodependenciesblock), sowebsocket-drivernever reaches the shipped bundle — it is only loaded bywebpack-dev-serverduring localnpm run dev. Exposure was dev-environment noise rather than a shipped vulnerability. CI (Prettier, tsc, Cypress E2E) fully covers the change.Related Tickets:
None — no Linear ticket. This addresses Dependabot alert #141.
Did you...
npm ci,npx tsc,npm run build,npm audit— websocket-driver advisories gone)npm run format:checkpasses)