fix: Tasks do no longer get marked as failed after being marked as completed (fixes #30)#33
Open
stchigel wants to merge 2 commits into
Open
fix: Tasks do no longer get marked as failed after being marked as completed (fixes #30)#33stchigel wants to merge 2 commits into
stchigel wants to merge 2 commits into
Conversation
Author
|
It didn't auto tag in the title but this is the issue: #30 |
Member
|
Hi @stchigel and welcome! Would you mind writing a proper description of the PR please? Both for clarity now and in the future. This sounds like a good bug fix, but how did you find it and how does the fix exactly work? There are also associated unit tests that now appear to break - see https://jenkins.terasology.io/job/Terasology/job/Modules/job/T/job/Tasks/job/PR-33/1/testReport/ |
Author
|
Hello @Cervator! Sorry about that, I'll write the description now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original problem was that sometimes a task that had already been completed would get marked as failed after some time
The problem in the code was that, when the quest was completed, some tasks of the quest would still have timers running, and if these timers ran out it would send a task failed event, making it so the quest would be marked as failed.
The proposed solution is that when a quest complete event is triggered, it removes the timers from every task that's part of that quest