test: expect the serialized form to use fully-qualified names#24
Merged
Conversation
Contributor
Author
|
I do think the type handler has enough code in it to be worth testing. Clearly there are some disadvantages to having the tests depend on the byte-for-byte result of the serialized form. Not sure what the better way would be. It could compare PersistedData structures instead of the JSON string, but that might have the same problem if the expected PersistedData hard-codes those class references. |
skaldarnar
approved these changes
Feb 23, 2021
Contributor
|
This fails because MTE is not binary compatible with MovingBlocks/Terasology#4539 (I think). I've triggered a rebuild of MTE and hope this will help (the tests run fine when testing this locally). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because MovingBlocks/Terasology#4148