fix: allow death due to fall damage and make the player face the opponents base#215
Draft
ahv15 wants to merge 2 commits into
Draft
fix: allow death due to fall damage and make the player face the opponents base#215ahv15 wants to merge 2 commits into
ahv15 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a player dies due to fall damage, the player doesn't teleport back to base. Also when the player teleports to the base, the player doesn't face the opposing base. Although by modifying the CharacterTeleportEvent the states and the components are updated properly the player doesn't teleport or change their orientation on death. Further investigation is necessary. Requires MovingBlocks/Terasology#4778 to test this.