Skip to content

Hide the Info share button and the comment invitation for roles without them - #51

Merged
TeoVader merged 1 commit into
mainfrom
fix/viewer-readonly-leftovers
Nov 11, 2026
Merged

TeoVader merged 1 commit into
mainfrom
fix/viewer-readonly-leftovers

Conversation

@TeoVader

Copy link
Copy Markdown
Owner

What changes

Found on a Pixel after #50, with a viewer member on a shared project:

  • The Info tab still showed "Share link", which opens the file's share links. It now shows only when the role can share (FileAccess.share), like the other share entries.
  • An empty comment list still said "Leave the first feedback…" to a role that can't comment. The body is now left out; the title stays and the note under the list ("Your role in this project lets you read comments…", from Hide the remaining write actions a project role can't perform #50) explains why.

No new strings.

Checks

  • ./gradlew :app:verifyRoborazziDebug :app:lintDebug: on CI
  • Tried on a phone: after CI, with the viewer member

🤖 Generated with Claude Code

…ut them

A viewer saw "Share link" in the Info tab and "Leave the first feedback"
on an empty comment list, though the role can do neither.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TeoVader
TeoVader merged commit ece2a57 into main Nov 11, 2026
2 checks passed
@TeoVader
TeoVader deleted the fix/viewer-readonly-leftovers branch November 11, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant