Repository navigation
Stop writing to a share when its editor opens - #45
Merged
Merged
Conversation
Opening the share editor ran a GET and then a PATCH of the name to get the settings the stable GET omits: a write just for looking, which could undo a rename made meanwhile. It now reads them with the experimental Show share (documented with layout, theme, versions, captions, watermark and template) and falls back to the stable GET; settings still missing show as unset, with a note, until the user changes one. Removing a reviewer or a file from a link asks first. A share link of the user's own account that opens in the app as the plain file or folder shows a short notice that the link's expiry, passphrase, download setting and watermark don't apply, with a button to open the link in the browser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # app/src/test/java/dev/finalish/ui/screenshots/ComponentsScreenshotTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Before:
After:
GET /v4/accounts/{a}/shares/{s}withapi-version: experimental), which documents layout, theme, accent colour, versions, transcripts, captions, watermark andwatermark_template_id. If that call fails it falls back to the stable GET. If the layout and viewer settings still don't come back, they show as unset (no layout or theme chip selected) under a short note, until the user changes one; that answer then fills them all in. A template id from the server now replaces the locally remembered one.FrameLinks.openInBrowserTab) and goes away after 12 s or on "Done". It shows on each such open, not once per install, so the way to the real link is always offered.How
FrameioApi.shareExperimental,FrameioRepository.shareDetails()(experimental, then stable;completesays which one answered),Share.watermarkTemplateId.ShareEditorSheet: no PATCH on open;settingsUnreadflag;ConfirmRemoveDialog.LinkTarget.FromShare(shareUrl, target)wraps what a share link resolves to;AppNavshowsShareAccessNoticeand then opens the target as before.share_access_notice. Its baseline comes from the CItest-reportartifact (Linux).Not verified against a live account (no real Frame.io calls during development): that the experimental GET returns these fields in practice, as documented.
Checks
./gradlew :app:verifyRoborazziDebug :app:lintDebugpasses (lint at 0)🤖 Generated with Claude Code