fix(security): enforce authentication on rate limits, deny unconfigured admin access, and sanitize git fetcher args - #673
Open
tarun1790 wants to merge 2 commits into
Conversation
…ed admin access, and sanitize git fetcher args
Collaborator
|
Thank you for your interest and contributions! We will review your code and get back to you as soon as possible! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This Pull Request resolves critical authentication bypasses and SSRF argument injection vulnerabilities across
MemoryProxyandMemoryKnowledge:Enforce Authentication on Admin Rate Limit Endpoints (
MemoryProxy/src/routes/rate-limits.ts):get,put, anddeletehandlers increateRateLimitHandlerswithcheckAdminAuth()validation to prevent unauthenticated query, override, or deletion of tenant rate limits.Deny Access on Unconfigured Admin Key (
MemoryProxy/src/routes/admin-auth.ts):checkAdminAuth()to return"missing"instead of"ok"whenconfig.admin.apiKeyis empty/unconfigured, protecting operational administrative routes (such as/v3/instance/proxy-destroy) from unauthenticated exposure.Sanitize Input Parameters in Git Source Fetcher (
MemoryKnowledge/src/source-fetcher/git-fetcher.ts):-c,--) insourceUrlbefore invokingsimpleGit().clone()to prevent argument injection attacks.Verification
MemoryProxyandMemoryKnowledge.