fix(deploy): resolve curl from PATH in Git Bash - #669
Open
luojiyin1987 wants to merge 2 commits into
Open
Conversation
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
luojiyin1987
marked this pull request as ready for review
August 1, 2026 05:34
Collaborator
|
Thank you for your interest and contributions! We will review your code and get back to you as soon as possible! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATHin the deployment scripts.CURL=/path/to/curloverride.Root cause
start-memory-core.shandverify.shassumed that curl exists at/usr/bin/curl.Git Bash can provide curl at a different path.
The scripts also converted command failures to HTTP
000and discarded stderr.User impact
Windows Git Bash can now use curl from
PATH.Linux and macOS keep their existing PATH behavior.
Operators can set an explicit curl executable through
CURL.Offline verification with
--skip-llmdoes not require curl.Validation
bash -n deploy/global-images/start-memory-core.sh deploy/global-images/verify.shshellcheck -x deploy/global-images/_lib.sh deploy/global-images/start-memory-core.sh deploy/global-images/verify.sh--skip-llmignoresCURL=/definitely/missing.CURL=/bin/false..envcan override an inheritedCURLvalue.CURL=curlresolution on Linux.Windows Git Bash validation remains pending.
The shell changes and failure paths have been validated on Linux.
An end-to-end Windows Git Bash test is still requested from the original reporter.
Fixes #655