Skip to content

fix(deploy): resolve curl from PATH in Git Bash - #669

Open
luojiyin1987 wants to merge 2 commits into
TencentCloud:feat/server_teamfrom
luojiyin1987:agent/deploy-curl-git-bash
Open

fix(deploy): resolve curl from PATH in Git Bash#669
luojiyin1987 wants to merge 2 commits into
TencentCloud:feat/server_teamfrom
luojiyin1987:agent/deploy-curl-git-bash

Conversation

@luojiyin1987

@luojiyin1987 luojiyin1987 commented Aug 1, 2026

Copy link
Copy Markdown

Summary

  • Resolve curl from PATH in the deployment scripts.
  • Support an explicit CURL=/path/to/curl override.
  • Check curl only when host-side LLM verification runs.
  • Report curl exit codes and preserve short error details.

Root cause

start-memory-core.sh and verify.sh assumed that curl exists at /usr/bin/curl.
Git Bash can provide curl at a different path.
The scripts also converted command failures to HTTP 000 and discarded stderr.

User impact

Windows Git Bash can now use curl from PATH.
Linux and macOS keep their existing PATH behavior.
Operators can set an explicit curl executable through CURL.
Offline verification with --skip-llm does not require curl.

Validation

  • bash -n deploy/global-images/start-memory-core.sh deploy/global-images/verify.sh
  • shellcheck -x deploy/global-images/_lib.sh deploy/global-images/start-memory-core.sh deploy/global-images/verify.sh
  • Verified that --skip-llm ignores CURL=/definitely/missing.
  • Verified a clear missing-curl error when LLM verification runs.
  • Verified exit-code output with CURL=/bin/false.
  • Verified that .env can override an inherited CURL value.
  • Verified default CURL=curl resolution on Linux.

Windows Git Bash validation remains pending.

The shell changes and failure paths have been validated on Linux.
An end-to-end Windows Git Bash test is still requested from the original reporter.

Fixes #655

Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
@luojiyin1987
luojiyin1987 marked this pull request as ready for review August 1, 2026 05:34
@Maxwell-Code07

Copy link
Copy Markdown
Collaborator

Thank you for your interest and contributions! We will review your code and get back to you as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] deploy:Windows Git Bash 下 start-all.sh 初始化 admin 失败报 HTTP=000(脚本硬编码 /usr/bin/curl)

2 participants