Skip to content

fix(build): remove incomplete seed-v2 script target - #652

Open
RerankerGuo wants to merge 1 commit into
TencentCloud:feat/server_teamfrom
RerankerGuo:fix/build-remove-stale-seed-v2
Open

fix(build): remove incomplete seed-v2 script target#652
RerankerGuo wants to merge 1 commit into
TencentCloud:feat/server_teamfrom
RerankerGuo:fix/build-remove-stale-seed-v2

Conversation

@RerankerGuo

Copy link
Copy Markdown

Description | 描述

Restore a clean npm run build on the repository's current default feat/server_team branch.

MemoryCore/package.json unconditionally included npm run build:seed-v2, which points TypeScript at scripts/seed-v2/tsconfig.json. That source directory and config have never existed in the v2 branch history, so every complete build ended with:

error TS5058: The specified path does not exist: 'scripts/seed-v2/tsconfig.json'.

The accompanying MemoryCore/bin/seed-v2.mjs was also unreachable as a published command:

  • it is absent from package.json#bin and package.json#files;
  • both its source and dist targets are absent;
  • direct execution always exits with neither dist nor source found.

Changes:

  • Remove the nonexistent build:seed-v2 step from build:scripts.
  • Remove the unreachable seed-v2 npm script.
  • Delete the dead launcher that cannot resolve either source or dist.

This does not remove a working or published feature. A future v2 seed client can be added atomically with source, build config, package export, tests, and documentation instead of leaving the default build broken.

Related Issue | 关联 Issue

No existing issue. Discovered while validating the current default branch during pr-contributor maintenance.

Change Type | 修改类型

  • Bug fix | Bug 修复
  • New feature | 新功能
  • Documentation update | 文档更新
  • Code optimization | 代码优化

Self-test Checklist | 自测清单

  • Verified locally | 本地验证通过
  • No existing features affected | 无影响现有功能

Additional Notes | 其他说明

Validation in MemoryCore (Node v26.5.0, npm v11.17.0):

npm run build
# plugin bundle + migrate-sqlite-to-vdb + export-tencent-vdb + read-local-memory: passed

npm pack --dry-run --ignore-scripts --json
# 326 files; contains_seed_v2=false

git diff --check
# passed

The feat/server_team branch currently contains no committed *.test.ts / *.spec.ts files, so there is no runnable unit suite for this packaging-only change. Full build and package-manifest verification cover the affected surface.

The v2 package invoked scripts/seed-v2/tsconfig.json from every build even though the source directory was never committed. Its unexported bin wrapper could only terminate with a missing source/dist error.

Remove the stale build and npm script entries together with the unreachable wrapper so the default feat/server_team branch builds and packs successfully again.

Signed-off-by: RerankerGuo <121015044+RerankerGuo@users.noreply.github.com>
@Maxwell-Code07

Copy link
Copy Markdown
Collaborator

Thank you for your interest and contributions! We will review your code and get back to you as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants