fix(build): remove incomplete seed-v2 script target - #652
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
The v2 package invoked scripts/seed-v2/tsconfig.json from every build even though the source directory was never committed. Its unexported bin wrapper could only terminate with a missing source/dist error. Remove the stale build and npm script entries together with the unreachable wrapper so the default feat/server_team branch builds and packs successfully again. Signed-off-by: RerankerGuo <121015044+RerankerGuo@users.noreply.github.com>
6 tasks
Collaborator
|
Thank you for your interest and contributions! We will review your code and get back to you as soon as possible! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description | 描述
Restore a clean
npm run buildon the repository's current defaultfeat/server_teambranch.MemoryCore/package.jsonunconditionally includednpm run build:seed-v2, which points TypeScript atscripts/seed-v2/tsconfig.json. That source directory and config have never existed in the v2 branch history, so every complete build ended with:The accompanying
MemoryCore/bin/seed-v2.mjswas also unreachable as a published command:package.json#binandpackage.json#files;neither dist nor source found.Changes:
build:seed-v2step frombuild:scripts.seed-v2npm script.This does not remove a working or published feature. A future v2 seed client can be added atomically with source, build config, package export, tests, and documentation instead of leaving the default build broken.
Related Issue | 关联 Issue
No existing issue. Discovered while validating the current default branch during
pr-contributormaintenance.Change Type | 修改类型
Self-test Checklist | 自测清单
Additional Notes | 其他说明
Validation in
MemoryCore(Node v26.5.0, npm v11.17.0):The
feat/server_teambranch currently contains no committed*.test.ts/*.spec.tsfiles, so there is no runnable unit suite for this packaging-only change. Full build and package-manifest verification cover the affected surface.