Skip to content

fix(connectors): enforce custom MCP module permission - #3025

Open
AbelTomato wants to merge 1 commit into
TencentCloud:developfrom
AbelTomato:fix/custom-mcp-permission
Open

AbelTomato wants to merge 1 commit into
TencentCloud:developfrom
AbelTomato:fix/custom-mcp-permission

Conversation

@AbelTomato

Copy link
Copy Markdown
Contributor

Summary

Fixed #3024

Enforce the connector_custom permission across custom MCP endpoints, including OAuth and connector-instance operations. Add coverage confirming unauthorized stdio probes return 403 without starting a host process.

Target branch

  • Base is develop (feature / fix — default)
  • Base is main (release/* or hotfix/* only)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactor / chore
  • Release / hotfix

Test plan

  • make all passes locally
  • Added/updated tests
  • uv run pytest tests/integration/test_connectors_api.py -k 'custom_mcp_routes_require or custom_mcp_patch_and_delete_require or custom_mcp_probe_requires or custom_mcp_instance_probe_requires' -q — 4 passed, 50 deselected.
  • Pre-commit Ruff, mypy, and dashboard build passed; Testmon selected no tests.
  • Full-suite run: 5,699 passed, 68 skipped, 20 deselected, 1 failed. The Laya test encountered less than 4 GiB free in /tmp; it passed when rerun after space recovered.

Checklist

  • Updated CHANGELOG.md (if user-facing)
  • README / docs updated (if needed)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant