Repository navigation
Conversation
export_workspace_zip() compressed archives, import_workspace_zip() extracted every entry, and replace-mode _clear_local_workspace() traversed and deleted directories — all inline on the asyncio event loop shared with API requests, chat streams and WebSockets. Large workspaces or slow filesystems therefore stalled unrelated traffic (TencentCloud#1596). Wrap the three blocking steps in asyncio.to_thread. Archive contents, path checks, hidden/system directory preservation and builtin-skill exclusions are unchanged. Fixes TencentCloud#1596
d25db43 to
e71bc38
Compare
…ive-offload # Conflicts: # CHANGELOG.md
|
Friendly follow-up — the workspace ZIP export/import work is offloaded from the async event loop, with focused archive regressions. Local backup tests passed (56 passed, 1 skipped); the full-suite environment failures are disclosed in the PR. The current fork CI run is awaiting maintainer approval, and GitHub currently reports no merge conflict. Could a maintainer approve CI and review the patch when convenient? Happy to adjust the scope or tests. |
Resolve CHANGELOG.md conflict: adopt the 1.0.2b7 release structure and re-add the workspace archive offload entry under [Unreleased] until this PR lands.
…ive-offload # Conflicts: # CHANGELOG.md
…ive-offload # Conflicts: # CHANGELOG.md
…ive-offload # Conflicts: # CHANGELOG.md
…ive-offload # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
|
This is ready to squash-merge; there is no reviewer assigned, so flagging it in case it fell off the queue.
Scope is unchanged: ZIP export packing, import extraction and the Happy to adjust anything, including narrowing it to just the export path if you would rather review the import side separately. |
Fixes #1596
Why
Workspace ZIP compression, extraction and replace-mode cleanup ran synchronously on the asyncio event loop shared by API requests, chat streams and WebSockets.
What changed
.envfiles.3d85f07e, preserving the archive fix and its Unreleased note.Surface area
Earlier validation (before the 2026-10-09 sync)
uv run --locked pytest tests/unit/backup -q -m "not live": 56 passed, 1 skipped (includes all 12 archive tests).PYTEST_ADDOPTS=tests/unit/backup, and dashboard production build. This scoped gate is not a passing full suite.make all PYTEST_JOBS=4completed its broad test run: 4,174 passed, 145 skipped, 2 failed. Failures are the unchanged Windows browser-profile path case (test_channels_qr.py) and Tencent mirror reachability probe case (test_docker_install.py), outside the archive patch. This is not a passing full suite; upstream CI remains necessary.git diff --checkpassed.AI assistance
Tool(s) used: AI coding agent
How you used it: inspected blocking call sites, added thread-identity regression tests, synchronized this branch with develop, resolved the release-note conflict, and ran the checks above. Broader test limitations are stated explicitly.
Latest synchronization and validation (2026-11-18)
Head
7a535b572121e7fdbd651cfd08115a94880365d3merges develop3d85f07e76122c7323448527809422f42a9f3666. Relative to that baseline, the PR contains only its implementation, regression tests and Unreleased fix entry.NODE_OPTIONS=--max-old-space-size=4096, matching the repository build configuration.