Skip to content

[bug] Custom MCP APIs bypass connector_custom permission #3024

Closed

Description

@AbelTomato

What happened

Custom MCP endpoints only check login. A user can still access or modify custom MCP settings after connector_custom permission is revoked. Testing an stdio MCP may start a host process.

Expected behavior

All custom MCP operations require connector_custom; denied requests return 403 before changing settings or starting a process.

Steps to reproduce

  1. Use an account without connector_custom.
  2. Call POST /api/connectors/custom-mcp/test with an stdio server.
  3. Verify the request is denied and no process starts.

Environment

  • octop version: affected develop commit
  • Python version: 3.x
  • OS: Linux
  • Install method: source

Logs / screenshots

Attach the 403 response and relevant logs. Redact credentials.

Activity

  1. jubaoliang commented on Nov 18, 2026

    @jubaoliang
    Collaborator

    Custom MCP GET, PUT, PATCH, and test now depend on connector_custom. A user without that permission gets 403 before the handler runs, so an stdio probe cannot start a host process.

    New users still receive this permission by default. The hole was only open after an admin revoked it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions