You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[bug] IM auto-pushes generated drafts before visual review accepts them #2859
In an image generation → visual review → revision workflow, IM recipients receive generated drafts before review has accepted them. A later send_file_to_user call cannot retract those drafts. This makes a request for one reviewed image produce several user-visible versions.
Observed with Octop 1.0.3b3 on the Weixin/iLink channel. The image-review plugin itself returns text and is not responsible for sending these drafts.
Reproduction
Enable image generation and a visual review tool for an agent.
Ask for a synthetic illustration and require review before delivery.
Generate image A; review rejects a visible defect.
Generate image B; review accepts it; explicitly send B.
Observe that image A was already delivered before its review finished.
Cause and scope
MEDIA_PUSH_TOOL_BASES in src/octop/infra/gateway/media/tool_media.py includes generate_image and generate_video. Their tool results are projected directly into outbound IM media events, independently of any later review or explicit delivery decision.
This is separate from #2351 / #2683 (workspace resolution and retry suppression) and #2283 / #2286 (image inspection). The current auto-push behavior predates those changes.
Expected behavior
Provide a defined way for reviewed-media workflows to keep drafts internal and deliver only explicitly selected artifacts. Preserve compatibility for workflows that intentionally rely on automatic generation-result delivery; the default/opt-in policy should be decided explicitly.
Acceptance coverage should include a rejected draft, an accepted final artifact, multiple revisions, and ordinary generation without a review workflow. Dashboard tool previews should remain usable without forcing a draft into IM delivery.
Privacy
This report uses synthetic names only. No screenshots, generated user images, chat text, server addresses, account identifiers, credentials, private filesystem paths, or production session identifiers are included.
Activity