docs(integrations): add LlamaIndex integration guide#285
Conversation
|
/cubebot review |
|
Claude finished @fslongjin's task in 57s —— View job Review: LlamaIndex Integration GuideThis is a well-structured documentation PR that adds a bilingual (EN/ZH) LlamaIndex integration guide following the project's contribution guidelines. The code examples are clear and the guide covers the full lifecycle from setup to advanced use cases. What's good
Issues to address
Overall, this is a solid contribution. The content is accurate, well-organized, and follows project conventions. The issues above are minor and relate mostly to code quality in the examples. |
|
Can you share your environment? The cold start taking 1-2 seconds is too slow for us, better stateful sandbox processing, as well as domain-based network access control, are in our plan and will be released soon |
|
@Johnny-zbb Thanks for submitting this LlamaIndex integration guide — the document structure is solid, and the bilingual (EN/ZH) coverage follows our contribution guidelines. I want to emphasize that integration tutorials must be verified against a real CubeSandbox deployment before submission, otherwise incorrect examples can mislead other users and cause significant confusion. After reviewing the code examples in this PR, I found several issues that suggest they haven't been run against an actual CubeSandbox instance: Critical: Template ID format is incorrectThe document uses See: Creating Templates from OCI Images — Step 3 shows the correct usage: Critical: Bare image lacks
|
- Replace invalid template_id='python:3.12-slim' with <your-template-id> placeholder
- Add template creation instructions to Prerequisites section
- Use SDK native network parameter for network isolation (network={"allow_out": [...]})
- Add config=cfg to Sandbox.create() calls in network examples
- Remove unused 'import json' statement
- Fix metadata={} usage to SDK-native parameters
- Complete Python example for LlamaIndex + CubeSandbox integration - Demonstrates RAG workflow with secure code execution - Includes network isolation examples - Bilingual README (English + Chinese) - Environment configuration templates
Do you mean that you also wrote the guide on adding LlamaIndex integration? |
Closes #244