fix(mcp): honor --dry-run for remove (#900) - #937
Merged
Merged
Conversation
The PR description includes a representative real-CLI E2E verification, so testing documentation is sufficient. |
|
No findings.
|
jeff-r2026
approved these changes
Oct 1, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teamai mcp remove --dry-runcurrently removes managed MCP servers because the global preview flag never reaches the remove handler. Forward it through config loading and the existing MCP reconciler, skip git-exclude cleanup during a preview, and label the output as a dry run.Type of Change
Test Plan
npm run buildnpm run typechecknpm run lintnpx vitest run src/__tests__/mcp-cmd.test.ts— 11 passednpx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/mcp-uninstall.test.ts— 1 passed; exercisesdist/index.jsand verifies MCP config and ownership manifest remain byte-for-byte unchanged aftermcp remove --dry-runThe full unit suite was attempted on Windows but did not pass: unrelated tests hit POSIX file-mode expectations, shell differences, file locks, and timeouts. Linux CI is needed for the full-suite result.
Related Issues
Refs #900 (
mcp removerow).Notes for Reviewers
The underlying MCP reconciler already supported
dryRun; this change only connects the command to it and avoids the separate git-exclude cleanup on a preview.