fix(pull): name the skills a pull removes because they are no longer delivered (#911) - #917
Open
rubenmarcus wants to merge 1 commit into
Open
rubenmarcus wants to merge 1 commit into
rubenmarcus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teamai pullnow names the skills it removes because they are no longer delivered here, in one info line. Before, a member who picked a role or project (or whose admin addedmanifest/projects.yaml) lost their root skills with only adebugline calling them "excluded" and a summary that saidNo resources to sync. When a removed skill is a root skill in role or project mode, the line also says how to get it back:teamai tags subscribe <tag>.Type of Change
Test Plan
npx tsc --noEmitpassesnpm run lintpasses (exit 0)npx vitest runpasses: 342 files, 5495 passed, 1 skippedTwo tests in
src/__tests__/pull-namespace-override.test.ts, following the proposal in the issue:teamai tags subscribe <tag>hintBoth fail on
main(3a9a24a) and pass with the fix:Real CLI, the reproduction from the issue (bare git team repo with
skills/shared-skill,teamai pull, then an admin addsmanifest/projects.yamlwith one project and the member pulls again with no--project).On
main:On this branch:
Related Issues
Fixes #911
Notes for Reviewers
src/pull.tscollects the removed names across tools into one set, so a skill removed from several tools is named once. Skills the member excluded withteamai excludekeep the olddebugline: that removal is what they asked for.cleanupInactiveNamespaceSkillsnow returns the names it removed and they join the same line, as the issue suggests. Its existing callers in tests ignore the return value.docs/usage-guide.mdanddocs/usage-guide.zh-CN.mdno longer say a member with no project still getscommon, and gain a bullet on root skills arriving through a tag.docs/designs/multi-project-management.mdnotes the skills exception on the<type>/root line. CHANGELOG entry under Unreleased / Bug Fixes.Prepared with AI assistance (Claude Opus 5.5 via Claude Code) and reviewed before submission.