fix(skills): mirror deleted files during push - #651
Merged
jeff-r2026 merged 1 commit intoSep 20, 2026
Merged
Conversation
The PR description includes a concrete test plan and real-CLI E2E record, so it satisfies the testing-documentation requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the local skill file set into the team repository during
teamai push. Previously,copyDirmerged files but never removed files deleted locally, so the CLI reported success while the team repository retained stale files and the skill stayed(modified)forever.Type of Change
Test Plan
npx tsc --noEmitpassesnpx vitest runpassesFocused tests:
npx vitest run src/__tests__/skills.test.ts src/__tests__/fs-compare.test.ts— 94/94 passednpm run build— passedgit diff --check— passedReal CLI E2E used a temporary local bare Git remote and the built CLI:
teamai push --skill ... --allpushed a real local branch.references/old.mdwas absent from the pushed branch.references/new.mdwas present.CONTRIBUTORSwas preserved and updated.The full suite reached 3,434/3,507 tests on Windows; the remaining failures are existing environment-sensitive POSIX path, permissions, shell, symlink, process, and network cases unrelated to this change.
Related Issues
Fixes #650
Notes for Reviewers
The mirror step reuses the existing recursive file walker, which already excludes ignored files such as
.git,node_modules,.DS_Store, and*.pyc. The rootCONTRIBUTORSfile is explicitly preserved. Empty directories are pruned using the existing helper.