Skip to content

fix(omp): report the extension status in hooks list - #648

Merged
jeff-r2026 merged 1 commit into
Tencent:mainfrom
jimpablo:fix/650-omp-hooks-list-status
Sep 20, 2026
Merged

jeff-r2026 merged 1 commit into
Tencent:mainfrom
jimpablo:fix/650-omp-hooks-list-status

Conversation

@jimpablo

Copy link
Copy Markdown
Contributor

Summary

Small follow-up to the merged #645, addressing its one review finding ([P2 non-blocking]): teamai hooks list reported OMP as "not configured" even with the teamai extension installed, because OMP has no settings/hooks path for the generic status check to parse. This adds an OMP-specific row that reports the extension file itself, and corrects the marker comment in omp-hooks.ts (it claimed doctor support — only uninstall and now hooks list check the marker; doctor has no extension-based check, same as it has none for the OpenCode plugin).

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature causing existing behavior to change)
  • Documentation only
  • Refactor / internal cleanup

Test Plan

  • npx tsc --noEmit passes
  • npx vitest run passes — 3506 tests / 249 files (branch is main + this commit only)
  • npm run build passes
  • Real-CLI verification (sandboxed HOME, local bare git fixture, git provider): after init + pull, teamai hooks list shows omp installed ~/.omp/agent/extensions/teamai-hooks.ts; after removing the extension file it shows omp missing ~/.omp/agent/extensions/teamai-hooks.ts:
--- with extension ---
omp              installed       ~/.omp/agent/extensions/teamai-hooks.ts
--- after removal ---
omp              missing         ~/.omp/agent/extensions/teamai-hooks.ts

Related Issues

Part of #550 (polish on the merged #645).

Notes for Reviewers

OpenCode's plugin has the same "not configured" display in hooks list (also no settings path) — pre-existing on main and out of scope here; happy to unify both rows in a follow-up if wanted.

Address the non-blocking review finding from Tencent#645: hooks list showed
OMP as 'not configured' even with the teamai extension installed,
because OMP has no settings/hooks path for the generic status check to
parse. Add an OMP-specific row that reports the extension file itself
(installed / missing), and correct the marker comment in omp-hooks.ts
(doctor does not check extensions; uninstall and hooks list do).
@github-actions

Copy link
Copy Markdown
  • [P1 blocking] src/hooks-cmd.ts:107 reports installed solely when the path exists; it never reads or validates TEAMAI_MARKER, despite the comments claiming marker recognition. An unrelated, empty, corrupted, or user-owned teamai-hooks.ts therefore produces a false “installed” status. Validate the file contents—ideally against the generated extension or at least the marker—before reporting installed, and cover both valid and non-TeamAI files.

The PR description includes a test plan and a real-CLI end-to-end record, so its testing notes are sufficient. I did not run any PR code, per instructions.

@jeff-r2026
jeff-r2026 merged commit f7205ed into Tencent:main Sep 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants