fix(omp): report the extension status in hooks list - #648
Merged
Merged
Conversation
Address the non-blocking review finding from Tencent#645: hooks list showed OMP as 'not configured' even with the teamai extension installed, because OMP has no settings/hooks path for the generic status check to parse. Add an OMP-specific row that reports the extension file itself (installed / missing), and correct the marker comment in omp-hooks.ts (doctor does not check extensions; uninstall and hooks list do).
The PR description includes a test plan and a real-CLI end-to-end record, so its testing notes are sufficient. I did not run any PR code, per instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up to the merged #645, addressing its one review finding (
[P2 non-blocking]):teamai hooks listreported OMP as "not configured" even with the teamai extension installed, because OMP has no settings/hooks path for the generic status check to parse. This adds an OMP-specific row that reports the extension file itself, and corrects the marker comment inomp-hooks.ts(it claimeddoctorsupport — onlyuninstalland nowhooks listcheck the marker; doctor has no extension-based check, same as it has none for the OpenCode plugin).Type of Change
Test Plan
npx tsc --noEmitpassesnpx vitest runpasses — 3506 tests / 249 files (branch ismain+ this commit only)npm run buildpassesgitprovider): afterinit+pull,teamai hooks listshowsomp installed ~/.omp/agent/extensions/teamai-hooks.ts; after removing the extension file it showsomp missing ~/.omp/agent/extensions/teamai-hooks.ts:Related Issues
Part of #550 (polish on the merged #645).
Notes for Reviewers
OpenCode's plugin has the same "not configured" display in
hooks list(also no settings path) — pre-existing on main and out of scope here; happy to unify both rows in a follow-up if wanted.