Repository navigation
feat(dsh): restore lightweight DSH plugin on unified bsk CLI runtime - #761
Merged
Merged
Conversation
Why: - Retiring `@wxg-prc-cpg/browser-skill-dsh-plugin` in Tencent#731 eliminated ~22k LOC of duplicated session lifecycle, cooperation plumbing, and React inspection overlays, but also dropped BrowserSkill's native distribution entry in the DeepSeek Harness (`dsh-plugin`) ecosystem and left existing npm consumers on a frozen 0.5.0 package. - DeepSeek Harness already provides shell execution and `ImplicitScopeRegistry` already isolates concurrent conversations via `DSH_SESSION_ID`, so the DSH plugin only needs to publish the canonical CLI skill, heal GUI/profile `PATH` lookup, and guide first-run `bsk` installation without reintroducing parallel `bsk_*` tool wrappers or fragile `@deepseek-ai/dsh-client-ui-*` `rc` locks. What: - Restore `packages/dsh-plugin-browserskill` (`@wxg-prc-cpg/browser-skill-dsh-plugin`) as a ~350-LOC Cordis plugin depending only on `@deepseek-ai/cordis` and `@deepseek-ai/schemastery` (zero `@deepseek-ai/dsh-*` host `rc` peer locks and zero Web UI client bundle). - Sync the canonical `crates/bsk-cli/skill` bundle, `install.sh`, `install.ps1`, `AGENT_INSTALL.md`, and `LICENSE` at build/prepack time so DSH shares the exact single-source-of-truth CLI skill and Agent Window workflow with all other harnesses. - Automatically append `~/.local/bin` (`$BSK_INSTALL_DIR`) to the DSH host `PATH` (and prepend any explicit `bskPath` directory, unwinding on dispose); when `bsk` is missing on the host, prepend an on-demand setup header pointing to the bundled cross-platform `bin/install-bsk.mjs` launcher and local `AGENT_INSTALL.md`, dropping the setup header automatically on subsequent conversations once `bsk` is installed. - Add end-to-end integration tests against real Cordis `Context` and `@deepseek-ai/dsh-skill` `SkillRegistry`, restore out-of-tree tarball verification (`scripts/check-dsh-package.mjs`), `dsh-plugin-v*` release automation (`.github/workflows/release-dsh-plugin.yml`, `scripts/release.mjs`), CI checks, and bilingual documentation/changelogs.
… cold 2x full-page captures Why: - After Wave 5A (Tencent#754) moved `content.js` to lazy runtime injection, cold 2x DPR SwiftShader full-page captures (`agent.browser.test.ts` `scale = 2` on 2-vCPU Linux CI runners) can overlap initial Tier-A ShadowRoot CSS/React mount and `CAPTURE_SUPPRESS` two-frame compositing with `runBrowserMutation` frame collection, intermittently exceeding the 1200ms per-frame IPC deadline with `FrameUnresponsiveError` (`effect_state: "none"`). - `guardedRunner.runBrowserMutation` also invoked `beginDomMutation()` followed immediately by `prepare()`, issuing two redundant back-to-back full-tab `collectCooperationFrames` sweeps per call, while `handleFullPageScreenshot` wrapped passive read-only `inspect` probes in `runBrowserMutation`. What: - Call `prepare(undefined, "Browser.mutate")` directly in `runBrowserMutation` (`action-guard.ts`), preserving full decision/expectation and pending-gesture verification in a single frame sweep before `dispatch(true, "Browser.mutate")`. - Skip `runBrowserMutation` on passive `inspect` probes in `handleFullPageScreenshot` (`screenshot-full-page.ts`). - Raise `FRAME_REPLY_TIMEOUT_MS` (`browser-bridge.ts`) and `OWNER_REPLY_MS` (`hidden-frames.ts`) from `1200ms` to `3000ms`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
@wxg-prc-cpg/browser-skill-dsh-pluginin Retire legacy DSH plugin package and enforce unified zero-skip real-browser CI gates #731 eliminated ~22k LOC of duplicated session lifecycle, cooperation plumbing, and React Web UI inspection overlays, but also removed BrowserSkill's native distribution entry in the DeepSeek Harness (dsh-plugin) ecosystem and left existing npm consumers pinned to a frozen0.5.0package.ImplicitScopeRegistryalready isolates concurrent conversations and subagents automatically viaDSH_SESSION_ID. Reintroducing a thin Cordis package preserves DSH plugin marketplace discoverability and seamlessdsh plugin add/dsh plugin updateworkflows while sharing 100% of the standardbskCLI + daemon + Agent Window architecture with all other harnesses.What
packages/dsh-plugin-browserskill, ~350 LOC):@wxg-prc-cpg/browser-skill-dsh-plugin,dsh-pluginkeywords, andcordis.patch.ymlwith only@deepseek-ai/cordisand@deepseek-ai/schemasterypeer dependencies (zero@deepseek-ai/dsh-*hostrcversion locks and zero Web UI client bundle).crates/bsk-cli/skillbundle,install.sh,install.ps1,AGENT_INSTALL.md, andLICENSEat build/prepack time — eliminating the second forked DSH skill definition.PATHself-healing & on-demand guided setup:~/.local/bin($BSK_INSTALL_DIR) to the DSH hostPATH(and prepends any configuredbskPathdirectory, unwinding on plugin dispose) so GUI/profile launches immediately resolvebsk.bskis not yet installed on the host, prepends a concise first-time setup section to the registered skill pointing to the bundled cross-platformbin/install-bsk.mjs(bsk-dsh-install) launcher and localAGENT_INSTALL.md(runningbsk doctorand guiding Chrome/Edge extension connection). Subsequent conversations automatically drop the setup header oncebskis installed..github/workflows/release-dsh-plugin.yml,dshtag/version coordination inscripts/release.mjs, and out-of-treenpm packtarball verification inscripts/check-dsh-package.mjs.@deepseek-ai/cordisContextand@deepseek-ai/dsh-skillSkillRegistry, wires them into.github/workflows/ci.yml, and updatesREADME.md,README.zh-CN.md,AGENT_INSTALL.md,CHANGELOG.md, andCHANGELOG.zh-CN.md.Verification
pnpm --filter @wxg-prc-cpg/browser-skill-dsh-plugin typecheckpnpm dsh:testnode scripts/check-dsh-package.mjsnode --test scripts/release.test.mjs scripts/check-skill-bundles.test.mjsnode scripts/check-skill-bundles.mjspython3 scripts/check-changelog-sync.pypnpm lint