Skip to content

fix(extension): bound debugger attach waits - #760

Open
yuanfengxixi wants to merge 1 commit into
Tencent:mainfrom
yuanfengxixi:fix/cdp-attach-timeout
Open

yuanfengxixi wants to merge 1 commit into
Tencent:mainfrom
yuanfengxixi:fix/cdp-attach-timeout

Conversation

@yuanfengxixi

Copy link
Copy Markdown

Summary

  • Bound chrome.debugger.attach to 10 seconds and return an explicit error when the browser API does not answer.
  • Keep an unresolved attach fenced; if it succeeds late, detach it before allowing another attach attempt. Preserve this fence through hard and soft-detached states.
  • Add regression coverage for a stuck attach, retries while the old request is pending, and cleanup after a late success.

Related to #452. This bounds the stuck-command failure mode; it does not claim to make Vivaldi's debugger attachment succeed, and no Vivaldi browser repro was available in this environment.

Validation

  • pnpm ext:test — 4,074 passed, 8 skipped.
  • pnpm --filter @browser-skill/extension compile — passed.
  • pnpm --filter @browser-skill/extension build — passed.
  • pnpm lint — passed.
  • python3 scripts/check-changelog-sync.py — passed.
  • git diff --check — passed.

Prepared with Codex assistance.

@yuanfengxixi
yuanfengxixi force-pushed the fix/cdp-attach-timeout branch from 750fa65 to d6be2a1 Compare November 17, 2026 21:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant