-
Notifications
You must be signed in to change notification settings - Fork 75
Generalise reserve margin constraints for region/tech groups #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
idelder
wants to merge
24
commits into
TemoaProject:unstable
Choose a base branch
from
idelder:rework/generalise_reserves
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
55aa6b5
Make some group region/tech indexing more clear
idelder 9bddd1b
Return region groups as sets for O(1) ownership checks and guaranteed…
idelder ec9c85f
Remove + delineated tech groups as loading does not support them. Als…
idelder f861d09
Generalise reserve margin constraints to any group of regions and techs
idelder 3defb16
Remove reserve margin method from config
idelder 3e48b67
Remove tech_reserve set and also therefore rps_requirement constraint…
idelder c2fb278
Create 4.1 schema with reserve update
idelder e1b3049
Update testing data
idelder f5e56e1
Update docs for reserve margin generalisation
idelder b49bdb1
Remember that annual exchange techs exist
idelder 93eaae1
Add reserve margin test that builds and checks for an identical LP file
idelder 0442f6b
Remember to increment db minor version
idelder abb291e
Add v4 to v4.1 migrator and test for it
idelder 5dff78b
Fix typing errors in testing folder
idelder 42bcc8c
Fix a log format
idelder 3cbbe84
Increment minor version of test dbs
idelder 5dce07e
Remove period filter from derate/credit tables
idelder 1ba59d9
Remove removed dict type
idelder b3e81d7
Fix a couple errors in docs
idelder 4d5260e
Fix some issues in v4 to 4.1 migrator
idelder 43725b3
Fix some docs notation
idelder e547a28
Add in-thread migration test for code coverage
idelder e8e5274
Consolidate schema version updating
idelder dd5baf6
Fix tutorial config so it doesnt ask appsi for duals
idelder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Name the v4.1 migration target explicitly.
Line 195 now points users to
temoa_schema_v4_1.sql, but Lines 199-200 still say thattemoa migratetransitions data to the V4 schema. Statev4.1explicitly so users understand the target minor version.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idelder, acknowledged. Would you like a follow-up issue for the V4.1 migration wording?🐇
You are interacting with an AI system.