Skip to content

good-first: aria-label on settings sidebar navigation #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FelineFantasy wants to merge 2 commits into
base: develop
Choose a base branch
from
+1 −1
Open

good-first: aria-label on settings sidebar navigation #610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb3b699
feat: add aria-label to settings sidebar navigation
FelineFantasy Jul 20, 2026
b5d98a6
Merge branch 'develop' into feat/add-settings-aria-label
FelineFantasy Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard/app/components/dashboard/settings/SettingsNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export function SettingsNav() {
<div className="mb-4 px-2 text-[11px] uppercase tracking-wider text-muted-foreground">
Settings
</div>
<nav className="space-y-5 text-sm">
<nav aria-label="Settings" className="space-y-5 text-sm">
{GROUPS.map((g) => (
<div key={g.label}>
<div className="mb-1 px-2 text-[10px] uppercase tracking-wider text-muted-foreground">
Expand Down
Loading