Fix concurrent error-group create race on ingest#599
Merged
Conversation
Catch Prisma P2002 on create, re-fetch the winner, and keep isNew true only for the creator so duplicate-fingerprint ingest no longer 500s. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
FelineFantasy
pushed a commit
to FelineFantasy/telemetry-tracker
that referenced
this pull request
Jul 20, 2026
…oup create race (Telemetry-Tracker#599). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /ingest/errorrequests for the same(project_id, fingerprint)can both missfindUniqueand both callcreate; the loser hit Prisma P2002 and 500'd.findOrCreateErrorGroupnow catches P2002, re-fetches the existing group, increments occurrences (same path as a normal hit), and returnsisNew: falseso only the create winner triggers new-group notifications.Test plan
pnpm lint && pnpm test && pnpm buildisNew: false/ingest/errorwith same fingerprint in staging after deployNote: safe to land on
developfor a patch ride alongside any in-flight v1.17 deploy.Made with Cursor