Update NuSpec and Correct Private Dependency#5
Open
jamesbar2 wants to merge 1 commit intoTeleSign:masterfrom
Open
Update NuSpec and Correct Private Dependency#5jamesbar2 wants to merge 1 commit intoTeleSign:masterfrom
jamesbar2 wants to merge 1 commit intoTeleSign:masterfrom
Conversation
Contributor
|
Hi @jamesbar2 , I'm a member of the Telesign product team. Thank you for bringing this to our attention, it seems like a reasonable change. We'll have our engineers take a look. |
|
@jamesbar2 Thanks for your patience on this. We reviewed it and can confirm that these issues have been resolved in the recent versions of the SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initially pulling in this project, we discovered that it doesn't compile out of the box. Because of the
<Private>True</Private>bit. With regards to the Nuspec other dependencies are required and they should be listed in the metadata in the Nuspec.Additionally, this made the project able to be built and can be loaded into a private Nuget repository. With these changes, we can hook into your repository and update our clients every time y'all update your package.
Screenshot from our private Nuget repository
Let me know if you have any questions!