Introduce interface for VerifyClient#2
Open
ammaraltahan wants to merge 5 commits intoTeleSign:masterfrom
Open
Conversation
Interface for VerifyClient comes very handy in unit testing, it is much easier to mock an interface than mock a concrete class.
for testing, it is much easier to mock an interface than a concrete class.
Contributor
|
Hi @ammaraltahan , I'm sorry for the very long delay in responding, but our product team will take a look at this request and see if it's something we can use. Thanks for contributing! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our telesign integration unit tests, we mock the class that makes and web requests to telesign restful endpoint because we simply do not want to make a service call every time we run unit tests, so in our end we had to introduce the interface and build it locally because mocking an interface is much easier than mocking a concrete class, but I think it might make sense if you introduce this interface to others too so we can spread the goodness, and I'm sure others are facing the same difficulty.