fix(share): render comment panel as full-width overlay on mobile view…#191
Open
Vrindakr3300 wants to merge 1 commit into
Open
fix(share): render comment panel as full-width overlay on mobile view…#191Vrindakr3300 wants to merge 1 commit into
Vrindakr3300 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #187. On mobile viewports (< 768px), the comment panel in both single-asset and folder share viewers now renders as a full-width overlay sheet over the media player instead of competing for horizontal space as a fixed 360px flex sibling.
Changes
apps/web/app/share/[token]/page.tsx):relativepositioning to the main flex container.ShareRightPanelstyling tow-full absolute inset-y-0 right-0 z-20 md:static md:w-[360px] md:inset-auto.FolderAssetViewer.apps/web/components/share/folder-share-viewer.tsx):relativepositioning toShareReviewInnermain flex container.w-full absolute inset-y-0 right-0 z-20 md:static md:w-[360px] md:inset-auto.## [Unreleased]->### Fixed.Testing
docker compose -f docker-compose.dev.yml exec -w /workspace api python -m pytest apps/api/tests/ -q)pnpm --filter web test && pnpm --filter web build)Checklist
CHANGELOG.mdentry added under## [Unreleased](for user-facing changes)