Skip to content

#6 Add Puzzles.get_batch#8

Open
nstillman-te wants to merge 1 commit intomasterfrom
feature/chess-122-puzzles-get-batch-#6
Open

#6 Add Puzzles.get_batch#8
nstillman-te wants to merge 1 commit intomasterfrom
feature/chess-122-puzzles-get-batch-#6

Conversation

@nstillman-te
Copy link
Copy Markdown

Part of #6.

Implements GET /api/puzzle/batch/{angle} as client.puzzles.get_batch(angle, difficulty=..., nb=..., color=...). Adds PuzzleBatchResponse and optional PuzzleUser fields (flair, patron, patronColor). VCR test for response validation and requests_mock test for query params. README.rst and CHANGELOG.rst updated.

Checklist when adding a new endpoint
  • Added new endpoint to the README.rst
  • Ensured that my endpoint name does not repeat the name of the client. Wrong: client.users.get_user(), Correct: client.users.get()
  • Typed the returned JSON using TypedDicts in berserk/types/, example
  • Written tests for GET endpoints not requiring authentification. Documentation, example
  • Added the endpoint and your name to CHANGELOG.rst in the To be released section (to be created if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant