Repository navigation
fix(ci): get every check passing - #161
Merged
Merged
Conversation
- clangd: link Homebrew llvm's clangd from a fail-soft task. The [dotfiles] entry pointed at a keg path that only exists after llvm is installed, so every macOS dry run failed. - macos job: raw mise refuses the runner's own ~/.bashrc; pass --force-dotfiles (bin/dotfiles sets such conflicts aside itself). - arch job: install diffutils; the wrapper needs cmp. The fixture now names a missing tool instead of linking an empty path. - system-sudoers job: Ubuntu 24.04 blocks unprivileged user namespaces; an AppArmor profile grants them to /usr/bin/bwrap only. - shellcheck: guard-or-die checks use if/then, k9s resolves its source from SCRIPTDIR, hammerspoon's trap handler also silences SC2329.
macOS TMPDIR sits behind the /var -> /private/var alias. bootstrap.py resolves HOME but not an explicit XDG_CONFIG_HOME, so its outside-HOME guard rejected the fixture's own paths. Fix the fixture, keep the guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the four red checks on main. One is a real bug: the macOS clangd dotfile entry pointed at a Homebrew keg path that doesn't exist until llvm is installed, so every macOS dry run failed; it's now a fail-soft bootstrap task.
The rest are CI environment gaps: the Arch container lacks diffutils (the wrapper needs cmp), the macOS runner ships its own ~/.bashrc that raw mise refuses to overwrite, and Ubuntu 24.04 blocks the user namespaces the sudoers test needs (an AppArmor profile now grants them to bwrap only). Shellcheck's info findings are fixed in place rather than silenced globally.