Merge To main: 7월 5주차#467
Merged
Merged
Conversation
feat: replace gtag.js with GTM script and add Hotjar tracking
[Feat/464] GTM 및 Hotjar 트래킹 코드 추가
- 기존 page 최상위에서 일괄적으로 px-4를 가지고 있었지만 횡스크롤 형 ui들은 px-4에 의해 잘리면 안되므로 해당 ui가 자체적으로 padding을 가지도록 변경함
- 사용자 유형에 따라 퀵메뉴가 존재하지 않음에도 그 container의 padding이 존재, 화면의 불필요한 공백 생성하고 있어 이를 제거함.
- HomePage 내 UI 레이아웃 변경에 따라 인사 문구 등을 출력하는 HomeGreetingSection, 이력서 완성도를 보여주는ResumeHelperBanner, 사용자 유형별 퀵메뉴를 제공하는 HomeMenu를 묶어 HomeTopSection 컴포넌트로 제공 - 기존 광고 배너 캐러셀을 제공했던 HomeBanner를 HomeBannerCarousel로 변경, HomePage에서 단독 호출
- 사용자 유형별로 공고/커리어 카드 내 요구 비자 리스트 문구를 출력하는 로직을 커스텀 훅으로 분리 - 로직 내 삼항 연산자 제거
- 로직과 ui 로직 상 중복되는 부분이 많은 홈/인재 검색에 사용되는 HomeEmployerEmployeeCardList와 EmployerEmployeeCardList에 사용되는 코드를 EmployeeCard로 통합했습니다.
- 커리어 리스트 요청시 기본 카테고리값 설정 - 커리어 api 훅 주석 수정 - 불필요한 store 조작 코드 제거
Feat/413 유저/기업 홈 수정
MrMirror21
added
🐞 BugFix
|
Warning Rate limit exceeded@MrMirror21 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 48 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (28)
📝 WalkthroughWalkthrough공통 EmployeeCard 및 관련 서브 컴포넌트가 신설되어 재사용성을 높이고, 홈 및 검색 관련 주요 섹션이 사용자 유형에 따라 트렌딩/북마크 리스트, 커리어, 이력서 등으로 리팩토링되었습니다. 또한, 구글 애널리틱스가 GTM 및 Hotjar로 대체되었으며, 검색 필터 포맷터와 비자 표기 유틸리티가 도입되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant HomePage
participant HomeTopSection
participant HomePostSection
participant EmployeeCard
participant useEmployeeCard
User->>HomePage: 페이지 진입
HomePage->>HomeTopSection: 렌더링
HomePage->>HomeBannerCarousel: 렌더링
HomePage->>HomePostSection: 렌더링
HomePostSection->>EmployeeCard: 트렌딩/북마크/이력서 리스트 렌더링
EmployeeCard->>useEmployeeCard: 북마크 클릭/상세 이동 핸들러 호출
useEmployeeCard-->>EmployeeCard: 북마크 토글/상세 페이지 이동
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Vitest Test Results📉 Coverage Warnings
🎉 All tests passed!Great job! All 177 tests are working correctly across 22 test files. 🔗 Quick Actions
🤖 Generated by GitHub Actions at 2025-08-01T06:23:40.608Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
[Feat/464] GTM 및 Hotjar 트래킹 코드 추가 #466
GTM 및 Hotjar 트래킹 코드 추가
Feat/413 유저/기업 홈 수정 #421
Uncompleted Tasks 😅
To Reviewers 📢
Summary by CodeRabbit
신규 기능
기능 개선
버그 수정
스타일
기타