PrezelDialog 컴포넌트 추가 및 modal 컴포넌트 구조 정리#94
Merged
Conversation
Closed
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough스낵바 구현을 Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/modal/dialog/PrezelDialog.kt`:
- Around line 37-44: The dialog currently sets usePlatformDefaultWidth = false
and the content uses modifier.fillMaxWidth(), allowing the dialog to expand to
the full screen; update the PrezelDialog configuration and content modifier to
constrain width: either set usePlatformDefaultWidth = true on the Dialog
parameters or keep usePlatformDefaultWidth = false but replace Column's
modifier.fillMaxWidth() with a width constraint (e.g., Modifier.widthIn(max =
<desired dp>) and center the Column) so the dialog remains a compact centered
modal; adjust the modifier references in PrezelDialog.kt (the Dialog args:
dismissOnClickOutside, usePlatformDefaultWidth and the Column's
modifier.fillMaxWidth()) accordingly.
In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/modal/dialog/PrezelDialogScope.kt`:
- Around line 30-40: Action 버튼 역할에 대한 시맨틱이 빠져 있어 스크린리더가 컨트롤을 인식하지 못하므로,
PrezelDialogScope의 액션 영역에서 사용되는 PrezelTouchArea 콜에 버튼 역할(Role.Button)을 명시해 주세요;
PrezelTouchArea를 호출하는 위치(현재 PrezelDialogScope.kt의 PrezelTouchArea(onClick =
onClick, shape = PrezelTheme.shapes.V4) { ... })에 Modifier.semantics { role =
Role.Button }를 적용하거나 PrezelTouchArea의 파라미터/구현에 role 설정을 추가하여 PrezelCheckbox에서
사용한 패턴과 동일하게 버튼 시맨틱을 설정하도록 수정하세요.
In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/theme/PrezelTheme.kt`:
- Line 72: LocalContentColor is being set to colorScheme.textRegular which makes
unspecified Text composables inherit a too-light color in dark mode; change the
provider in PrezelTheme.kt to use colorScheme.textLarge as the default
LocalContentColor so unspecified Text keeps the original, higher-contrast color,
and only set colorScheme.textRegular on individual Text usages that explicitly
need a lighter tone (e.g., replace the LocalContentColor provides
colorScheme.textRegular line with provides colorScheme.textLarge and audit
usages like TermsScreen/HistoryScreen to remove redundant explicit colors).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 11ed4100-8d54-4fdc-b149-ef82c8251361
📒 Files selected for processing (8)
Prezel/app/src/main/java/com/team/prezel/ui/DoubleBackToExitHandler.ktPrezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/PrezelNavigationBar.ktPrezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/modal/dialog/PrezelDialog.ktPrezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/modal/dialog/PrezelDialogScope.ktPrezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/modal/snackbar/PrezelSnackbar.ktPrezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/modal/snackbar/SnackbarHost.ktPrezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/theme/PrezelTheme.ktPrezel/feature/login/impl/src/main/java/com/team/prezel/feature/login/impl/landing/LoginScreen.kt
...ystem/src/main/java/com/team/prezel/core/designsystem/component/modal/dialog/PrezelDialog.kt
Show resolved
Hide resolved
.../src/main/java/com/team/prezel/core/designsystem/component/modal/dialog/PrezelDialogScope.kt
Show resolved
Hide resolved
Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/theme/PrezelTheme.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용
PrezelDialog와PrezelDialogScope.Action을 추가했습니다.component/modal/snackbar패키지로 이동하고 참조 경로를 정리했습니다.🧩 관련 이슈
📸 스크린샷
📢 논의하고 싶은 내용
Summary by CodeRabbit
릴리스 노트
새로운 기능
개선 사항