fix: resolve CORS misconfiguration vulnerability (allow_origins wildcard with credentials)#139
Open
namann5 wants to merge 1 commit into
Open
Conversation
…ildcard Critical security fix: Using allow_origins=['*'] with allow_credentials=True violates the CORS specification and allows any external website to make authenticated requests to the API. This enables cross-origin credential leakage attacks where malicious sites can exfiltrate user data. The fix: - Moves allowed origins to Settings.CORS_ORIGINS config - Restricts to specific development origins (localhost:5173, localhost:3000) - Allows easy configuration via .env for production deployments
namann5
force-pushed
the
fix/cors-misconfiguration-vulnerability
branch
from
74b97fa to
03028d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CORS misconfiguration vulnerability - using
allow_origins=["*"]withallow_credentials=Trueviolates the CORS spec and allows any external website to make credentialed requests.Changes
backend/app/config.py: AddedCORS_ORIGINSconfig setting with specific allowed originsbackend/app/main.py: Changed fromallow_origins=["*"]toallow_origins=settings.CORS_ORIGINSSecurity Impact
Per RFC 6454,
Access-Control-Allow-Origin: *must NOT be used withAccess-Control-Allow-Credentials: true. Starlette reflects the origin back when credentials are enabled, making any origin able to read authenticated responses.Related Issue
Closes #138