fix: prevent scheduled interview fetch failure by separating read and…#105
Open
harshitanagpal05 wants to merge 4 commits into
Open
fix: prevent scheduled interview fetch failure by separating read and…#105harshitanagpal05 wants to merge 4 commits into
harshitanagpal05 wants to merge 4 commits into
Conversation
Contributor
|
@harshitanagpal05 Thanks for the pr, but please review your agent generated code before raising a PR, it saves maintainers. Please drop all the changes to the non related files and just have a single commit with prefix |
9f53962 to
6895bdc
Compare
6895bdc to
0c00924
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #86 where
GET /interviews/{interview_id}would fail for valid interviews after their scheduled times had passed.Problem
The response schema was inadvertently applying create-time validation rules (future-date checks) to read operations, causing the endpoint to fail when fetching interviews with past scheduled times.
Solution
CustomInterviewReadResponse: A new read-only schema without the future-date validatorGET /interviews/{interview_id}to useCustomInterviewReadResponseinstead ofCustomInterviewResponsestart_time,end_time,submission_deadlinemust be in the futuredsa_score + dev_score == 100Changes
CustomInterviewReadResponseand refactored to use a base schemaTesting
python -m compileall