Skip to content

refactor: remove redundant tests for Firebase environment variable ha… #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YaraSenousy merged 1 commit into from
May 3, 2026
Merged

refactor: remove redundant tests for Firebase environment variable ha… #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions src/common/utilities/captcha.util.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import axios from 'axios';

import { getApps, initializeApp, cert } from 'firebase-admin/app';
import { getApps, initializeApp } from 'firebase-admin/app';
import { getAppCheck } from 'firebase-admin/app-check';
import { verifyCaptcha, getFirebaseApp, verifyAppCheckToken } from './captcha.util';

Expand Down Expand Up @@ -86,26 +86,6 @@ describe('getFirebaseApp', () => {
expect(result).toBe(mockApp);
expect(initializeApp).not.toHaveBeenCalled();
});

it('should throw Error when env vars are missing', () => {
(getApps as jest.Mock).mockReturnValue([]);
delete process.env.FIREBASE_PROJECT_ID;

expect(() => getFirebaseApp()).toThrow(
'Missing Firebase env vars: FIREBASE_PROJECT_ID, FIREBASE_CLIENT_EMAIL, FIREBASE_PRIVATE_KEY'
);
});

it('should call initializeApp with cert when env vars are present', () => {
(getApps as jest.Mock).mockReturnValue([]);
(cert as jest.Mock).mockReturnValue({ credential: 'mock-cert' });
(initializeApp as jest.Mock).mockReturnValue(mockApp);

getFirebaseApp();

expect(cert).toHaveBeenCalled();
expect(initializeApp).toHaveBeenCalled();
});
});

describe('verifyAppCheckToken', () => {
Expand Down
Loading