Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion args.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -3502,7 +3502,21 @@ namespace args
std::vector<std::string> args;
if (argc > 1 && argv != nullptr)
{
args.assign(argv + 1, argv + argc);
args.reserve(static_cast<std::vector<std::string>::size_type>(argc - 1));
for (int i = 1; i < argc; ++i)
{
if (argv[i] == nullptr)
{
#ifdef ARGS_NOEXCEPT
error = Error::Parse;
errorMsg = "argv contains a null argument";
return false;
#else
throw ParseError("argv contains a null argument");
#endif
}
args.emplace_back(argv[i]);
}
}

return ParseArgs(args) == std::end(args);
Expand Down
16 changes: 16 additions & 0 deletions test/parsecli_null_argv.cxx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#include "test_helpers.hxx"
#include "args.hxx"

int main()
{
args::ArgumentParser parser("parser");

const char *argv[] = {"prog", "--flag", nullptr};

test::require_throws_as<args::ParseError>([&]
{
parser.ParseCLI(3, argv);
});

return 0;
}
Loading