Avoid relying on peek()-after-failbit semantics in ParseNumericValue#169
Merged
Merged
Conversation
Owner
|
Looks fine to me, where "fine" means "iostreams is awful, but this gets the job done". Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueReader::ParseNumericValuepreviously relied on the interactionbetween std::ws, stream failbit state, and std::istream::peek() to detect trailing non-whitespace input.On MSVC, extracting
std::wsat EOF sets failbit in addition to eofbit. The previous logic still behaved correctly because peek() returns EOF when the stream is failed, but the control flow depended on subtle stream semantics.Make the trailing-input check explicit by attempting to extract one additional non-whitespace character and distinguishing EOF from other stream failures directly.
No intended behavior change.