Repository navigation
fix(macos): build native agent for macOS 14+ - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the macOS native agent compatibility issue where the distributed binary could be built with the host macOS deployment target instead of the intended macOS 14 minimum target.
The previous build script invoked
swiftcdirectly and bypassed the.macOS(.v14)deployment target declared inPackage.swift, which could produce a binary requiring newer macOS runtime libraries.Changes
Package.swiftis the single source of truth for the deployment targetLSMinimumSystemVersionValidation
minos=14.0libswift_DarwinFoundation2.dylibFull ScreenCaptureKit permission and screenshot interaction flows are not exercised in CI.
Fixes #1