fix(install): prevent 404 text overwrite and add CLI flags - #2
Merged
Merged
Conversation
- Use curl fail flag and ELF binary verification before placing binary - Fall back to cargo install from source if GitHub release is not yet published - Add --help and --version CLI flag handling in main.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.sh: Usescurl -sSfLand ELF binary validation to prevent 404 text ('Not Found') from overwriting the binary file when a pre-built GitHub release does not yet exist.install.shautomatically compiles and installs from source viacargo install.-h/--helpand-v/--versionargument handling insrc/main.rs.