fix(nix): resolve missing Cargo.toml and Cargo.lock by using upstream niri flake overlay - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25
Problem
Lniri was refactored into a pure overlay repository, keeping only modified files under
src/andresources/. However,flake.nixstill attempted to build using local paths to./Cargo.tomland./Cargo.lock(which were removed from this repo), causingnix buildto fail with:Solution
github:niri-wm/niri/v26.04) as a flake input withinputs.nixpkgs.follows = "nixpkgs".src/render_helpers/,niri-config/src/appearance.rs,src/layer/mapped.rs, etc.) directly onto the unpacked upstream source viaoverrideAttrsinpostPatch.postInstallto provide bothlniriandLnirisymlinks alongsideniri, generate shell completions forlniri, and install desktop entry, portal configuration, session launcher, and systemd units with properly patched binary paths.flake.lockwith locked inputs forniri,nixpkgs, andrust-overlay.nix flake showandnix eval.